Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only write input file scaffold, if it doesn’t exist already #8

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Only write input file scaffold, if it doesn’t exist already #8

merged 2 commits into from
Dec 12, 2022

Conversation

s2k
Copy link
Contributor

@s2k s2k commented Dec 10, 2022

I also started to find the overwriting of the input file in the scaffolding code, a bit annoying.
Therefore this pull request.

(I generally think overwriting existing files without notice should be avoided. Guess how I came to that conclusion. 🙂)

@s2k
Only write input file scaffold, if it doesn’t exist already
d3a73a6 
Signed-off-by: Stephan Kämper <the.tester@seasidetesting.com>
@s2k
Fix file system check
22ab97b 
Signed-off-by: Stephan Kämper <the.tester@seasidetesting.com>
egiurleo
egiurleo approved these changes Dec 12, 2022
View reviewed changes
Copy link
Owner

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree and was eventually going to make this change, but you saved me the work. Thank you :)

@egiurleo egiurleo merged commit ce6d79e into egiurleo:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s2k @egiurleo